wu-arch/vortex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[driver] Fix bug in addr range check for upload/download

Browse Source 
Device address should not be compared against LOCAL_MEM_SIZE but against
an absolute max address.  Introduce new DEVICE_MAX_ADDR for this.
This commit is contained in:
Hansung Kim
2023-10-07 21:18:27 -07:00
parent 6ffb8c37e9
commit 46a60cf58e
3 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
driver/simx/vortex.cpp
View File

@@ -93,7 +93,7 @@ public:
int upload(const void* src, uint64_t dest_addr, uint64_t size, uint64_t src_offset) {
uint64_t asize = aligned_size(size, CACHE_BLOCK_SIZE);
if (dest_addr + asize > LOCAL_MEM_SIZE)
if (dest_addr + asize > DEVICE_MAX_ADDR)
return -1;
ram_.write((const uint8_t*)src + src_offset, dest_addr, asize);
@@ -108,7 +108,7 @@ public:
int download(void* dest, uint64_t src_addr, uint64_t size, uint64_t dest_offset) {
uint64_t asize = aligned_size(size, CACHE_BLOCK_SIZE);
if (src_addr + asize > LOCAL_MEM_SIZE)
if (src_addr + asize > DEVICE_MAX_ADDR)
return -1;
ram_.read((uint8_t*)dest + dest_offset, src_addr, asize);
@@ -354,4 +354,4 @@ extern int vx_ready_wait(vx_device_h hdevice, uint64_t timeout) {
vx_device *device = ((vx_device*)hdevice);
return device->wait(timeout);
}
}