wu-arch/vortex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tensor: Fix inflight_tensor decrement, add under/overflow checks

Browse Source
This commit is contained in:
Hansung Kim
2024-10-24 14:36:29 -07:00
parent 8337488ed3
commit 3ebeb43568
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
hw/rtl/core/VX_scoreboard.sv
View File

@@ -248,6 +248,20 @@ module VX_scoreboard import VX_gpu_pkg::*; #(
.ready_out (scoreboard_if[i].ready) .ready_out (scoreboard_if[i].ready)
); );
// inflight_tensor overflow/underflow check
`RUNTIME_ASSERT(
!(writeback_fire && writeback_if[i].data.tensor) ||
inflight_tensor[writeback_if[i].data.wis] != INFLT_WIDTH'(0),
("%t: *** core%0d: wid=%0d, underflow at inflight_tensor!",
$time, CORE_ID, wis_to_wid(writeback_if[i].data.wis, i))
)
`RUNTIME_ASSERT(
!(ibuffer_if[i].valid && ibuffer_if[i].ready && hgmma_start) ||
inflight_tensor[ibuffer_if[i].data.wis] != INFLT_MAX,
("%t: *** core%0d: wid=%0d, overflow at inflight_tensor!",
$time, CORE_ID, wis_to_wid(ibuffer_if[i].data.wis, i))
)
always @(posedge clk) begin always @(posedge clk) begin
if (reset) begin if (reset) begin
inuse_regs <= '0; inuse_regs <= '0;
@@ -261,8 +275,8 @@ module VX_scoreboard import VX_gpu_pkg::*; #(
end end
`ifdef EXT_T_HOPPER `ifdef EXT_T_HOPPER
if (writeback_fire && writeback_if[i].data.tensor) begin if (writeback_fire && writeback_if[i].data.tensor) begin
inflight_tensor[ibuffer_if[i].data.wis] <= inflight_tensor[writeback_if[i].data.wis] <=
inflight_tensor[ibuffer_if[i].data.wis] - INFLT_WIDTH'(1); inflight_tensor[writeback_if[i].data.wis] - INFLT_WIDTH'(1);
end end
if (ibuffer_if[i].valid && ibuffer_if[i].ready && hgmma_start) begin if (ibuffer_if[i].valid && ibuffer_if[i].ready && hgmma_start) begin
inflight_tensor[ibuffer_if[i].data.wis] <= inflight_tensor[ibuffer_if[i].data.wis] <=