wu-arch/radiance
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed MemTracerDriverImp to only terminate when all outstanding reqs are reclaimed

Browse Source 
This is for slightly more accurate perf numbers.
This commit is contained in:
Vamber Yang
2023-05-19 03:16:52 -07:00
parent d234b8c09a
commit d88a734aee
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/scala/tilelink/Coalescing.scala
View File

@@ -242,12 +242,15 @@ class RoundRobinSourceGenerator(sourceWidth: Int, ignoreInUse: Boolean = true)
val gen = Input(Bool()) val gen = Input(Bool())
val reclaim = Input(Valid(UInt(sourceWidth.W))) val reclaim = Input(Valid(UInt(sourceWidth.W)))
val id = Output(Valid(UInt(sourceWidth.W))) val id = Output(Valid(UInt(sourceWidth.W)))
val inflight = Output(Bool())
}) })
val head = RegInit(UInt(sourceWidth.W), 0.U) val head = RegInit(UInt(sourceWidth.W), 0.U)
head := Mux(io.gen, head + 1.U, head) head := Mux(io.gen, head + 1.U, head)
// for debugging // for debugging
// also for indicating if there is at least one inflight request that hasn't been reclaimed
val outstanding = RegInit(UInt((sourceWidth + 1).W), 0.U) val outstanding = RegInit(UInt((sourceWidth + 1).W), 0.U)
io.inflight := outstanding > 0.U
val numSourceId = 1 << sourceWidth val numSourceId = 1 << sourceWidth
// true: in use, false: available // true: in use, false: available
@@ -1468,13 +1471,14 @@ class MemTraceDriverImp(
// Give some slack time after trace EOF to the downstream system to make sure // Give some slack time after trace EOF to the downstream system to make sure
// we receive all (hopefully) outstanding responses back. // we receive all (hopefully) outstanding responses back.
val finishCounter = RegInit(200.U(64.W)) val traceFinished = RegInit(false.B)
when(sim.io.trace_read.finished) { when(sim.io.trace_read.finished) {
finishCounter := finishCounter - 1.U traceFinished := true.B
} }
io.finished := (finishCounter === 0.U) val allReqReclaimed = !(sourceGens.map(_.io.inflight).reduce(_ || _))
when(io.finished) {
when(traceFinished && allReqReclaimed) {
assert( assert(
false.B, false.B,
"\n\n\nsimulation Successfully finished\n\n\n (this assertion intentional fail upon MemTracer termination)" "\n\n\nsimulation Successfully finished\n\n\n (this assertion intentional fail upon MemTracer termination)"