From caa5ebf9434a0e3b60d0e2775f55b058e4addd16 Mon Sep 17 00:00:00 2001
From: Hansung Kim <hansung_kim@berkeley.edu>
Date: Sat, 6 May 2023 01:47:33 -0700
Subject: [PATCH] Reformat MemTraceReader

---
 src/main/resources/csrc/SimMemTrace.cc       | 44 +++++++-------------
 src/main/resources/csrc/SimMemTraceLogger.cc |  3 +-
 2 files changed, 18 insertions(+), 29 deletions(-)

diff --git a/src/main/resources/csrc/SimMemTrace.cc b/src/main/resources/csrc/SimMemTrace.cc
index 5f7a9ee..ca411b2 100644
--- a/src/main/resources/csrc/SimMemTrace.cc
+++ b/src/main/resources/csrc/SimMemTrace.cc
@@ -63,8 +63,7 @@ void MemTraceReader::parse() {
 // Try to read a memory request that might have happened at a given cycle, on a
 // given SIMD lane (= "thread").  In case no request happened at that point,
 // return an empty line with .valid = false.
-MemTraceLine MemTraceReader::read_trace_at(const long cycle,
-                                           const int lane_id,
+MemTraceLine MemTraceReader::read_trace_at(const long cycle, const int lane_id,
                                            unsigned char trace_read_ready) {
   MemTraceLine line;
   line.valid = false;
@@ -79,43 +78,39 @@ MemTraceLine MemTraceReader::read_trace_at(const long cycle,
   // It should always be guaranteed that we consumed all of the past lines, and
   // the next line is in the future.
   if (line.cycle < cycle) {
-    // fprintf(stderr, "line.cycle=%ld, cycle=%ld\n", line.cycle, cycle);
     printf("cycle=%ld, some lines are left in past Fatal", cycle);
     assert(false && "some trace lines are left unread in the past");
     return MemTraceLine{};
   }
 
-  if (line.lane_id != lane_id) {
-    line.valid = false;
-  }
   if (line.cycle > cycle) {
     // We haven't reached the cycle mark specified in this line yet, so we don't
     // read it right now.
     return MemTraceLine{};
+  } else if (line.lane_id != lane_id) {
+    return MemTraceLine{};
   } else if (line.cycle == cycle && line.lane_id == lane_id) {
 
-    if (trace_read_ready){
+    if (trace_read_ready) {
       printf("Fire! cycle=%ld, valid=%d, %s addr=%lx, size=%d \n", cycle,
-            line.valid, (line.is_store ? "STORE" : "LOAD"), line.address,
-            line.log_data_size);
+             line.valid, (line.is_store ? "STORE" : "LOAD"), line.address,
+             line.log_data_size);
 
-      // FIXME! Currently lane_id is assumed to be in round-robin order, e.g.
-      // 0->1->2->3->0->..., both in the trace file and the order the caller calls
-      // this function.  If this is not true, we cannot simply monotonically
-      // increment read_pos.
-      // Only advance pointer when cycle and threa_id both match
-      // now increaseing sequence is fine (0, 1, 3), but unordered is not fine (0, 3, 1)
+      // NOTE: Currently lane_id is assumed to be in always-increasing order,
+      // e.g. 0->1->2->3->0->..., both in the trace file and the order the
+      // caller calls this function.  If this is not true, we cannot simply
+      // monotonically increment read_pos.  lane_id need not be contiguous, e.g.
+      // 0->1->3 is fine.
       ++read_pos;
-    }
-    else {    // we do not want to advance read_pos
+    } else { // we do not want to advance read_pos
       printf("All Lanes Blocked on this cycle! cycle=%ld \n", cycle);
     }
-  
-    return line;
 
-   }
+    return line;
   }
-                                          
+
+  assert(!"unreachable");
+}
 
 extern "C" void memtrace_init(const char *filename) {
 #ifndef NO_VPI
@@ -155,13 +150,6 @@ extern "C" void memtrace_query(unsigned char trace_read_ready,
   // printf("memtrace_query(cycle=%ld, tid=%d)\n", trace_read_cycle,
   //        trace_read_lane_id);
 
-  /* we can't return immediately, even if trace is ready, we still want to find out
-     if we are suppose to generate valid req on this clock cycle
-  if (!trace_read_ready) {
-    return;
-  }
-  */
-
   auto line = reader->read_trace_at(trace_read_cycle, trace_read_lane_id, trace_read_ready);
   *trace_read_valid = line.valid;
   *trace_read_address = line.address;
diff --git a/src/main/resources/csrc/SimMemTraceLogger.cc b/src/main/resources/csrc/SimMemTraceLogger.cc
index 647aeb5..3963417 100644
--- a/src/main/resources/csrc/SimMemTraceLogger.cc
+++ b/src/main/resources/csrc/SimMemTraceLogger.cc
@@ -102,7 +102,8 @@ extern "C" void memtracelogger_log(int handle,
                     .data = trace_log_data,
                     .log_data_size = trace_log_size};
 
-  assert(0 <= handle && handle < loggers.size() && "wrong trace logger handle");
+  assert(0 <= handle && static_cast<size_t>(handle) < loggers.size() &&
+         "wrong trace logger handle");
   auto logger = loggers[handle].get();
   logger->write_line_to_trace(line);
 }