wu-arch/radiance
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix generating PutPartialData from toTLA

Browse Source 
Including mask in the argument calls the method override that generates
PutPartialData.
This commit is contained in:
Hansung Kim
2023-04-23 11:53:42 -07:00
parent 0c0a8ec553
commit b6115cc394
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/scala/tilelink/Coalescing.scala
View File

@@ -102,7 +102,6 @@ class ReqQueueEntry(sourceWidth: Int, sizeWidth: Int, addressWidth: Int, maxSize
toAddress = this.address, toAddress = this.address,
lgSize = this.size, lgSize = this.size,
data = this.data, data = this.data,
mask = this.mask
) )
val (glegal, gbits) = edgeOut.Get( val (glegal, gbits) = edgeOut.Get(
fromSource = this.source, fromSource = this.source,
@@ -303,6 +302,11 @@ class CoalescingUnitImp(outer: CoalescingUnit, config: CoalescerConfig) extends
req.address := tlIn.a.bits.address req.address := tlIn.a.bits.address
req.data := tlIn.a.bits.data req.data := tlIn.a.bits.data
req.size := tlIn.a.bits.size req.size := tlIn.a.bits.size
// FIXME: req.data is still containing TL-aligned data. This is fine if
// we're simply passing through this data out the other end, but not if
// the outgoing TL edge (tlOut) has different data width from the incoming
// edge (tlIn). Possible TODO to only store the relevant portion of the
// data, at the cost of re-aligning at the outgoing end.
req.mask := tlIn.a.bits.mask req.mask := tlIn.a.bits.mask
assert(reqQueue.io.queue.enq.ready, "reqQueue is supposed to be always ready") assert(reqQueue.io.queue.enq.ready, "reqQueue is supposed to be always ready")
@@ -689,6 +693,7 @@ class InflightCoalReqTableEntry(
object TLUtils { object TLUtils {
def AOpcodeIsStore(opcode: UInt): Bool = { def AOpcodeIsStore(opcode: UInt): Bool = {
// 0: PutFullData, 1: PutPartialData, 4: Get
assert( assert(
opcode === TLMessages.PutFullData || opcode === TLMessages.Get, opcode === TLMessages.PutFullData || opcode === TLMessages.Get,
"unhandled TL A opcode found" "unhandled TL A opcode found"