From a71c0aed739557accacc3e4c8a99411e40f32d87 Mon Sep 17 00:00:00 2001 From: Hansung Kim Date: Sun, 23 Apr 2023 12:07:52 -0700 Subject: [PATCH] Don't set default filename in class initializers --- src/main/scala/tilelink/Coalescing.scala | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/scala/tilelink/Coalescing.scala b/src/main/scala/tilelink/Coalescing.scala index 7377524..3014a96 100644 --- a/src/main/scala/tilelink/Coalescing.scala +++ b/src/main/scala/tilelink/Coalescing.scala @@ -709,7 +709,7 @@ object TLUtils { } } -class MemTraceDriver(config: CoalescerConfig, filename: String = "vecadd.core1.thread4.trace")(implicit +class MemTraceDriver(config: CoalescerConfig, filename: String)(implicit p: Parameters ) extends LazyModule { // Create N client nodes together @@ -922,7 +922,7 @@ class MemTraceLogger( numLanes: Int, // base filename for the generated trace files. full filename will be // suffixed depending on `reqEnable`/`respEnable`/`loggerName`. - filename: String = "vecadd.core1.thread4.trace", + filename: String, reqEnable: Boolean = true, respEnable: Boolean = true, // filename suffix that is unique to this logger module. @@ -1190,12 +1190,14 @@ object TracePrintf { class TLRAMCoalescerLogger(implicit p: Parameters) extends LazyModule { // TODO: use parameters for numLanes val numLanes = 4 - val driver = LazyModule(new MemTraceDriver(defaultConfig)) + // val filename = "test.trace" + val filename = "vecadd.core1.thread4.trace" + val driver = LazyModule(new MemTraceDriver(defaultConfig, filename)) val coreSideLogger = LazyModule( - new MemTraceLogger(numLanes, loggerName = "coreside") + new MemTraceLogger(numLanes, filename, loggerName = "coreside") ) val coal = LazyModule(new CoalescingUnit(defaultConfig)) - val memSideLogger = LazyModule(new MemTraceLogger(numLanes + 1, loggerName = "memside")) + val memSideLogger = LazyModule(new MemTraceLogger(numLanes + 1, filename, loggerName = "memside")) val rams = Seq.fill(numLanes + 1)( // +1 for coalesced edge LazyModule( // NOTE: beatBytes here sets the data bitwidth of the upstream TileLink