wu-arch/chipyard
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #2 from ucb-bar/option-alter-quibble

Browse Source 
Change spec to show a better way to change options
This commit is contained in:
Chick Markley
2016-12-14 11:07:58 -08:00
committed by GitHub
parent a1c7742a57 4b6110f0f6
commit e21e50dd91
1 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
executionoptions/src/test/scala/bar/executionoptions/ExecutionOptionsManagerSpec.scala
View File

@@ -16,16 +16,38 @@ class ExecutionOptionsManagerSpec extends FreeSpec with Matchers {
manager.topName should be ("dog") manager.topName should be ("dog")
manager.commonOptions.topName should be ("dog") manager.commonOptions.topName should be ("dog")
} }
"The add method should put a new version of a given type the manager" in { "The proper way to change an option in is to copy the existing sub-option with the desired new value" in {
val manager = new ExecutionOptionsManager("test") { commonOptions = CommonOptions(topName = "dog") } val manager = new ExecutionOptionsManager("test") {
commonOptions = CommonOptions(targetDirName = "fox", topName = "dog")
}
val initialCommon = manager.commonOptions val initialCommon = manager.commonOptions
initialCommon.targetDirName should be ("fox")
initialCommon.topName should be ("dog") initialCommon.topName should be ("dog")
manager.commonOptions = CommonOptions(topName = "cat") manager.commonOptions = manager.commonOptions.copy(topName = "cat")
val afterCommon = manager.commonOptions val afterCommon = manager.commonOptions
afterCommon.topName should be ("cat") afterCommon.topName should be ("cat")
afterCommon.targetDirName should be ("fox")
initialCommon.topName should be ("dog") initialCommon.topName should be ("dog")
} }
"The following way of changing a manager should not be used, as it could alter other desired values" - {
"Note that the initial setting targetDirName is lost when using this method" in {
val manager = new ExecutionOptionsManager("test") {
commonOptions = CommonOptions(targetDirName = "fox", topName = "dog")
}
val initialCommon = manager.commonOptions
initialCommon.topName should be("dog")
manager.commonOptions = CommonOptions(topName = "cat")
val afterCommon = manager.commonOptions
initialCommon.topName should be("dog")
afterCommon.topName should be("cat")
// This is probably bad
afterCommon.targetDirName should not be "fox"
}
}
} }
} }