From a55594bd0c1feda0fd9c8aef1dc5cd7e4b1e13d3 Mon Sep 17 00:00:00 2001 From: Abraham Gonzalez Date: Wed, 3 Nov 2021 11:24:37 -0700 Subject: [PATCH 1/3] Update pull request template [ci skip] --- .github/PULL_REQUEST_TEMPLATE.md | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4949e777..b10927ba 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,27 @@ -**Related issue**: +**Related PRs / Issues **: + -**Type of change**: bug fix | new feature | other enhancement +**Type of change**: +- [ ] bug fix +- [ ] new feature +- [ ] other enhancement -**Impact**: rtl change | software change | unknown | other +**Impact**: +- [ ] rtl change +- [ ] software change +- [ ] unknown +- [ ] other + + +**Contributer Checklist**: +- [ ] Did you set `dev` as the base branch? +- [ ] Did you add documentation for the feature? +- [ ] Did you add a test demonstrating the PR? +- [ ] Did you delete any extraneous prints/debugging code? + +- [ ] (If applicable) Did you mark the PR as "Please Backport"? **Release Notes** From e1b9f938f0857a666dc1e3a3e1ef8a503686f528 Mon Sep 17 00:00:00 2001 From: Abraham Gonzalez Date: Thu, 4 Nov 2021 16:54:30 -0700 Subject: [PATCH 2/3] Small changes [ci skip] --- .github/PULL_REQUEST_TEMPLATE.md | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b10927ba..34fd6ebd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,23 +3,25 @@ **Type of change**: -- [ ] bug fix -- [ ] new feature -- [ ] other enhancement +- [ ] Bug fix +- [ ] New feature +- [ ] Other enhancement **Impact**: -- [ ] rtl change -- [ ] software change -- [ ] unknown -- [ ] other +- [ ] RTL change +- [ ] Software change (RISC-V software) +- [ ] Build system change +- [ ] Other - -**Contributer Checklist**: + +**Contributor Checklist**: +- [ ] Yes, I specified the "Type of Change" +- [ ] Yes, I specified the "Impact" - [ ] Did you set `dev` as the base branch? -- [ ] Did you add documentation for the feature? -- [ ] Did you add a test demonstrating the PR? - [ ] Did you delete any extraneous prints/debugging code? +- [ ] (If applicable) Did you add documentation for the feature? +- [ ] (If applicable) Did you add a test demonstrating the PR? - [ ] (If applicable) Did you mark the PR as "Please Backport"? From c90576288a6e1c3c7a83f8cd534c699ccc8d4e44 Mon Sep 17 00:00:00 2001 From: Abraham Gonzalez Date: Thu, 4 Nov 2021 17:43:26 -0700 Subject: [PATCH 3/3] Address reviewer comments [ci skip] --- .github/PULL_REQUEST_TEMPLATE.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 34fd6ebd..b3c1c40f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,8 +16,6 @@ **Contributor Checklist**: -- [ ] Yes, I specified the "Type of Change" -- [ ] Yes, I specified the "Impact" - [ ] Did you set `dev` as the base branch? - [ ] Did you delete any extraneous prints/debugging code? - [ ] (If applicable) Did you add documentation for the feature?