Address PR comments

This commit is contained in:
Abraham Gonzalez
2022-08-23 00:58:30 +00:00
parent 1de35a6af4
commit 3c2bbd4bfd
9 changed files with 20 additions and 6 deletions

View File

@@ -31,7 +31,7 @@ body:
description: OS setup for reproducibility description: OS setup for reproducibility
placeholder: OS information placeholder: OS information
value: | value: |
Ex: Output of `uname -a` and `lsb_release -a` Ex: Output of `uname -a` / `lsb_release -a` / `printenv`
validations: validations:
required: true required: true

View File

@@ -52,6 +52,11 @@ dir="generators"
branches=("master" "main" "dev") branches=("master" "main" "dev")
search search
submodules=("riscv-tools" "esp-tools")
dir="toolchains"
branches=("main")
search
submodules=("coremark" "firemarshal" "nvdla-workload" "spec2017") submodules=("coremark" "firemarshal" "nvdla-workload" "spec2017")
dir="software" dir="software"
branches=("master" "dev") branches=("master" "dev")

View File

@@ -4,7 +4,6 @@ CONDA_INSTALL_PREFIX=/opt/conda
CONDA_INSTALLER_VERSION=4.12.0-0 CONDA_INSTALLER_VERSION=4.12.0-0
CONDA_INSTALLER="https://github.com/conda-forge/miniforge/releases/download/${CONDA_INSTALLER_VERSION}/Miniforge3-${CONDA_INSTALLER_VERSION}-Linux-x86_64.sh" CONDA_INSTALLER="https://github.com/conda-forge/miniforge/releases/download/${CONDA_INSTALLER_VERSION}/Miniforge3-${CONDA_INSTALLER_VERSION}-Linux-x86_64.sh"
CONDA_CMD="conda" # some installers install mamba or micromamba CONDA_CMD="conda" # some installers install mamba or micromamba
CONDA_ENV_NAME="firesim"
DRY_RUN_OPTION="" DRY_RUN_OPTION=""
DRY_RUN_ECHO=() DRY_RUN_ECHO=()

6
.gitmodules vendored
View File

@@ -97,3 +97,9 @@
[submodule "generators/fft-generator"] [submodule "generators/fft-generator"]
path = generators/fft-generator path = generators/fft-generator
url = https://github.com/ucb-bar/FFTGenerator.git url = https://github.com/ucb-bar/FFTGenerator.git
[submodule "toolchains/esp-tools"]
path = toolchains/esp-tools
url = https://github.com/ucb-bar/esp-tools-feedstock.git
[submodule "toolchains/riscv-tools"]
path = toolchains/riscv-tools
url = https://github.com/ucb-bar/riscv-tools-feedstock.git

View File

@@ -29,7 +29,7 @@ RUN git clone https://github.com/ucb-bar/chipyard.git && \
cd chipyard && \ cd chipyard && \
git checkout $CHIPYARD_HASH git checkout $CHIPYARD_HASH
RUN ./chipyard/scripts/install-conda.sh RUN ./chipyard/.github/scripts/install-conda.sh
# BUILD IMAGE WITH TOOLCHAINS # BUILD IMAGE WITH TOOLCHAINS

View File

@@ -27,7 +27,7 @@ Conda allows users to create an "environment" that holds system dependencies lik
First Chipyard requires there to be Conda installed on the system. First Chipyard requires there to be Conda installed on the system.
Please refer to the `Conda installation instructions <https://docs.conda.io/projects/conda/en/latest/user-guide/install/index.html>`__ on how to install Conda. Please refer to the `Conda installation instructions <https://docs.conda.io/projects/conda/en/latest/user-guide/install/index.html>`__ on how to install Conda.
Afterwards, verify that Conda is a sufficient version (we test on version 4.12.0/4.13.0). Afterwards, verify that Conda is a sufficient version (we test on version 4.12.0/4.13.0 but higher is most likely fine).
.. code-block:: shell .. code-block:: shell
@@ -40,7 +40,7 @@ This ``git`` is only used to first checkout the repository, we will later instal
Setting up the Chipyard Repo Setting up the Chipyard Repo
------------------------------------------- -------------------------------------------
Start by checkout out the proper Chipyard's version. Run: Start by checking out the proper Chipyard's version. Run:
.. parsed-literal:: .. parsed-literal::
@@ -66,7 +66,7 @@ Next run the following command to create Chipyard's Conda environment.
conda env create -f scripts/conda-requirements.yml conda env create -f scripts/conda-requirements.yml
By running the following command you should see a "chipyard" environment listed (the default environment is called "chipyard"). By running the following command you should see a "chipyard" environment listed (the default environment is called "chipyard" and can be modified with ``conda`` arguments).
.. code-block:: shell .. code-block:: shell

View File

@@ -76,6 +76,7 @@ cd "$CHIPYARD_DIR"
( (
# Blocklist of submodules to initially skip: # Blocklist of submodules to initially skip:
# - Toolchain submodules
# - Generators with huge submodules (e.g., linux sources) # - Generators with huge submodules (e.g., linux sources)
# - FireSim until explicitly requested # - FireSim until explicitly requested
# - Hammer tool plugins # - Hammer tool plugins
@@ -83,6 +84,7 @@ cd "$CHIPYARD_DIR"
# Call the given subcommand (shell function) on each submodule # Call the given subcommand (shell function) on each submodule
# path to temporarily exclude during the recursive update # path to temporarily exclude during the recursive update
for name in \ for name in \
toolchains/* \
generators/sha3 \ generators/sha3 \
generators/gemmini \ generators/gemmini \
sims/firesim \ sims/firesim \

1
toolchains/esp-tools Submodule

Submodule toolchains/esp-tools added at a1af866ef8