From 0c4cfc8742c42a9280d8ae263dd066d35ba8cbd8 Mon Sep 17 00:00:00 2001 From: Sagar Karandikar Date: Wed, 15 Feb 2023 17:57:26 -0800 Subject: [PATCH] Fix input files list emission to avoid bash "too many arguments" error This makes the expansion of "cat $(VLSI_RTL)" happen as a child of the shell that runs the for loop. The existing version will sometimes produce a bash "too many arguments" error because the $(shell cat $(VLSI_RTL)) is expanded first and then passed as a giant command to bash. --- vlsi/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vlsi/Makefile b/vlsi/Makefile index 0693db7e..339e3c80 100644 --- a/vlsi/Makefile +++ b/vlsi/Makefile @@ -122,7 +122,7 @@ $(SYN_CONF): $(VLSI_RTL) echo "synthesis.inputs:" >> $@ echo " top_module: $(VLSI_TOP)" >> $@ echo " input_files:" >> $@ - for x in $(shell cat $(VLSI_RTL)); do \ + for x in $$(cat $(VLSI_RTL)); do \ echo ' - "'$$x'"' >> $@; \ done