gh0s7/mckernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sched_setparam: thread lock is necessary when update other thread data

Browse Source
This commit is contained in:
Tomoki Shirasawa
2016-11-28 14:04:44 +09:00
parent 1130cafe41
commit bbb55ef261
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
kernel/syscall.c
View File

@@ -5590,8 +5590,8 @@ SYSCALL_DECLARE(sched_setparam)
struct sched_param param; struct sched_param param;
struct thread *thread = cpu_local_var(current); struct thread *thread = cpu_local_var(current);
struct mcs_rwlock_node_irqsave lock; struct mcs_rwlock_node_irqsave lock;
struct syscall_request request1 IHK_DMA_ALIGN; struct syscall_request request1 IHK_DMA_ALIGN;
int other_thread = 0;
dkprintf("sched_setparam: pid: %d, uparam: 0x%lx\n", pid, uparam); dkprintf("sched_setparam: pid: %d, uparam: 0x%lx\n", pid, uparam);
@@ -5603,12 +5603,11 @@ SYSCALL_DECLARE(sched_setparam)
pid = thread->proc->pid; pid = thread->proc->pid;
if (thread->proc->pid != pid) { if (thread->proc->pid != pid) {
other_thread = 1;
thread = find_thread(pid, pid, &lock); thread = find_thread(pid, pid, &lock);
if (!thread) { if (!thread) {
return -ESRCH; return -ESRCH;
} }
// TODO: unlock 場所のチェック
// 何をしようとしているのか理解
thread_unlock(thread, &lock); thread_unlock(thread, &lock);
/* Ask Linux about ownership.. */ /* Ask Linux about ownership.. */
@@ -5627,7 +5626,17 @@ SYSCALL_DECLARE(sched_setparam)
return -EFAULT; return -EFAULT;
} }
return setscheduler(thread, thread->sched_policy, &param); if (other_thread) {
thread = find_thread(pid, pid, &lock);
if (!thread) {
return -ESRCH;
}
}
retval = setscheduler(thread, thread->sched_policy, &param);
if (other_thread) {
thread_unlock(thread, &lock);
}
return retval;
} }
SYSCALL_DECLARE(sched_getparam) SYSCALL_DECLARE(sched_getparam)