gh0s7/mckernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

flatten_strings: do not return unused trailing bits

Browse Source 
Trailing bits were displayed in proc->saved_cmdline, displaying
uninitialized data to the user in /proc/<pid>/cmdline

Change-Id: I74831c8c68dd2f2197b35e9b49aaaae29c4c1dd5
This commit is contained in:
Dominique Martinet
2018-08-25 03:36:30 +09:00
committed by Dominique Martinet
parent 8db36c3828
commit 70e52faf36
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
executer/user/mcexec.c
View File

@@ -1073,7 +1073,7 @@ int flatten_strings(char *pre_strings, char **strings, char **flat)
_flat[nr_strings + pre_strings_count + 1] = p - (char *)_flat; _flat[nr_strings + pre_strings_count + 1] = p - (char *)_flat;
*flat = (char *)_flat; *flat = (char *)_flat;
return full_len; return p - (char *)_flat;
} }
//#define NUM_HANDLER_THREADS 248 //#define NUM_HANDLER_THREADS 248

2
lib/string.c
View File

@@ -333,5 +333,5 @@ int flatten_strings_from_user(char *pre_strings, char **strings, char **flat)
_flat[nr_strings + pre_strings_count + 1] = p - (char *)_flat; _flat[nr_strings + pre_strings_count + 1] = p - (char *)_flat;
*flat = (char *)_flat; *flat = (char *)_flat;
return full_len; return p - (char *)_flat;
} }