gh0s7/mckernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mcctrl: replace GFP_TEMPORARY by GFP_KERNEL

Browse Source 
See linux's commit 0ee931c4 ("mm: treewide: remove GFP_TEMPORARY
allocation flag") for a long explanation, but basically that flag
"is just cargo cult" and should be removed

Change-Id: I2147cd65b6b9ec509a72e11cc3abf1fe1561c10b
This commit is contained in:
Dominique Martinet
2018-07-26 18:07:34 +09:00
committed by Balazs Gerofi
parent 6999d0a3f9
commit 0a0a78ac2e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
executer/kernel/mcctrl/control.c
View File

@@ -1750,13 +1750,13 @@ int mcexec_open_exec(ihk_os_t os, char * __user filename)
return -EINVAL; return -EINVAL;
} }
pathbuf = kmalloc(PATH_MAX, GFP_TEMPORARY); pathbuf = kmalloc(PATH_MAX, GFP_KERNEL);
if (!pathbuf) { if (!pathbuf) {
retval = -ENOMEM; retval = -ENOMEM;
goto out; goto out;
} }
kfilename = kmalloc(PATH_MAX, GFP_TEMPORARY); kfilename = kmalloc(PATH_MAX, GFP_KERNEL);
if (!kfilename) { if (!kfilename) {
retval = -ENOMEM; retval = -ENOMEM;
kfree(pathbuf); kfree(pathbuf);

4
executer/kernel/mcctrl/syscall.c
View File

@@ -1205,7 +1205,7 @@ static int pager_get_path(struct file *file, char *path) {
int error = 0; int error = 0;
char *pathbuf, *fullpath; char *pathbuf, *fullpath;
pathbuf = kmalloc(PATH_MAX, GFP_TEMPORARY); pathbuf = kmalloc(PATH_MAX, GFP_KERNEL);
if (!pathbuf) { if (!pathbuf) {
printk("%s: ERROR: allocating path\n", __FUNCTION__); printk("%s: ERROR: allocating path\n", __FUNCTION__);
error = -ENOMEM; error = -ENOMEM;
@@ -1313,7 +1313,7 @@ static int pager_req_create(ihk_os_t os, int fd, uintptr_t result_pa)
{ {
char *pathbuf, *fullpath; char *pathbuf, *fullpath;
pathbuf = kmalloc(PATH_MAX, GFP_TEMPORARY); pathbuf = kmalloc(PATH_MAX, GFP_KERNEL);
if (pathbuf) { if (pathbuf) {
fullpath = d_path(&file->f_path, pathbuf, PATH_MAX); fullpath = d_path(&file->f_path, pathbuf, PATH_MAX);
if (!IS_ERR(fullpath)) { if (!IS_ERR(fullpath)) {